mfs redo #1715
Merged
mfs redo #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
force-pushed
the
mfs-redo
branch
from
04594dd
to
b8912bc
Compare
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
force-pushed
the
mfs-redo
branch
from
b8912bc
to
72c0282
Compare
| @@ -121,12 +169,8 @@ func (s *Root) Lookup(ctx context.Context, name string) (fs.Node, error) { | |||
| return nil, fuse.ENOENT | |||
| } | |||
|
|
|||
| // Local symlink to the node ID keyspace | |||
| if name == "local" { | |||
There was a problem hiding this comment.
yeap, that was bugging me for a while.
|
few comments, but LGTM biggest one is whether the republisher should be in ipnsfs instead, with mfs always calling the client func |
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
|
@jbenet comments fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extraction of the refactoring that i did to the core 'ipnsfs' code, applied on top of dev0.4.0