Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the #foo references absolute instead of relative. #1723

Closed
wants to merge 1 commit into from
Closed

Make the #foo references absolute instead of relative. #1723

wants to merge 1 commit into from

Conversation

spikebike
Copy link

No description provided.

@GitCop
Copy link

GitCop commented Sep 18, 2015

There were the following issues with your Pull Request

  • Commit: 5ae70a7
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

Guidelines and a script are available to help. Your feedback on GitCop is welcome on this issue.


This message was auto-generated by https://gitcop.com

@jbenet jbenet added the backlog label Sep 18, 2015
@jbenet
Copy link
Member

jbenet commented Sep 18, 2015

@spikebike thanks but we probably should just run a post-processing script in https://github.com/ipfs/website/ -- not here. (this script does not KNOW where the page will be hosted)

@jbenet
Copy link
Member

jbenet commented Sep 23, 2015

@RichardLitt saw you PRed something similar. we can just run a sed replace over the output, over at the website repo.

@RichardLitt
Copy link
Member

@jbenet Actually, I think that the gencmdref script should be moved to the website repo. I'm working on a branch for that in ipfs/website branch cmdref-make, but I am waiting on a solution to #1735 to figure that out.

@jbenet
Copy link
Member

jbenet commented Sep 25, 2015

Ok sounds good, though this is useful to make api docs independent of the website. Maybe this should be in an api repo, once we make it


Sent from Mailbox

On Wed, Sep 23, 2015 at 4:09 PM, Richard Littauer
notifications@github.com wrote:

@jbenet Actually, I think that the gencmdref script should be moved to the website repo. I'm working on a branch for that in ipfs/website branch cmdref-make, but I am waiting on a solution to #1735 to figure that out.

Reply to this email directly or view it on GitHub:
#1723 (comment)

@RichardLitt
Copy link
Member

Agreed, but the script as it is now is entirely website specific. Any later API scripts can be dealt with when we cross that bridge.

@jbenet
Copy link
Member

jbenet commented Sep 26, 2015

Ok sgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants