allow bitswap stat to return total number of bytes wasted #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with your Pull Request
Guidelines and a script are available to help. Your feedback on GitCop is welcome on this issue. This message was auto-generated by https://gitcop.com |
|
LGTM. only:
|
bitswap stat can now track bytes that are wasted by receiving duplicate blocks. ps, gitcop smells License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
force-pushed
the
feat/stat-count
branch
from
d0f6d8b
to
0c74216
Compare
|
@jbenet fixed commit message |
|
i saw that :P |
jbenet
added a commit
that referenced
this pull request
Sep 25, 2015
allow bitswap stat to return total number of bytes wasted
|
and now it's forever in history |
|
hahaha, i was hoping nobody would notice for at least a few months, maybe during a bisect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ion1 This adds the counter for the total number of bytes received due to duplicate blocks. Is there anything else you think we need here?
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com