if bucket doesnt have enough peers, grab more elsewhere #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| peerArr = copyPeersFromList(id, peerArr, bucket.list) | ||
| if len(peerArr) < count { | ||
| // In the case of an unusual split, one bucket may be short or empty. | ||
| // if this happens, search both surrounding buckets for nearby peers |
There was a problem hiding this comment.
this will end up with "more than count" peers, as it will copy from both other buckets, and copy doesn't have a limit.
There was a problem hiding this comment.
@jbenet right, read the rest of the function, especially line 177.
|
we need to go through the dht carefully cc @diasdavid |
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
force-pushed
the
fix/kbucket-fill
branch
from
df0be33 to
06bc124
Compare
|
rerunning tests |
|
mmm... i'll take some time next week to flush out those random test failures |
jbenet
added a commit
that referenced
this pull request
Nov 20, 2015
if bucket doesnt have enough peers, grab more elsewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the bucket chosen by the common prefix length doesnt have as many peers as we are requesting, grab some from the buckets on either side, This should help dht queries complete faster as they are more likely to query a larger number of peers.
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com