Add correct access control headers to the default api config

[dignifiedquire]

Nedded to fix ipfs-inactive/js-ipfs-http-client#76 and for ipfs-inactive/js-ipfs-http-client#128 for details why this is needed see: ipfs-inactive/js-ipfs-http-client#76 (comment)

---

Probably lots wrong with this, so please excuse any obvious mistakes

[daviddias]

LGTM, thank you for catching this one @dignifiedquire :)

For more context: https://botbot.me/freenode/ipfs/2015-11-19/?msg=54525489&page=9

[whyrusleeping]

@dignifiedquire you'll need to fix the type your using in the config init:

HTTPHeaders: map[string][]string{

[daviddias]

@whyrusleeping I was looking at that and wondering if it would make more sense to have the config coming from the JSON blob, instead of .go generating the config (this way could be one of those global things that other implementations use)

[whyrusleeping]

@diasdavid i'm not sure what youre saying. The JSON blob gets loaded into this struct so its easier to work with in go. (types are nice, mkay)

[daviddias]

@whyrusleeping If I'm reading it right, when ipfs init is done, the config json file is created and then loaded from there. But what if we shipped the default config in a json file with the code?

[dignifiedquire]

Will fix the type in the morning..

[whyrusleeping]

@diasdavid, some of the config is generated dynamically to make changing certain values easier.

[jbenet]

add them also to Gateway, because gateway also has an API. (we need to rename these... not sure on good names)

[dignifiedquire]

@jbenet sorry not sure where exactly, do you mean on l. 83?

[dignifiedquire]

@whyrusleeping I fixed the tests, anything else that I should do?

[jbenet]

I meant add the same headers to the "Gateway" config key as well.
On Fri, Nov 20, 2015 at 11:17 Friedel Ziegelmayer notifications@github.com
wrote:

@whyrusleeping https://github.com/whyrusleeping I fixed the tests,
anything else that I should do?

—
Reply to this email directly or view it on GitHub
#1979 (comment).

[dignifiedquire]

@jbenet done (or so I think)

[whyrusleeping]

this LGTM, though it seems kinda hacky, is this a config option we would ever want to change? if not, maybe it should go into the gateway code, and be hardcoded in?

[dignifiedquire]

@whyrusleeping tbh you know this better than I, these headers are directly dependent on the headers you are using in the api, so as long as you don't change those you don't have to change these here.

[dignifiedquire]

@jbenet @whyrusleeping we really need this in 0.3.10 this is causing issues for a lot of people trying to use js-ipfs-api. Do you need anything else from my side?

[jbenet]

well, i think if this is needed it shouldn't be a config value-- +1 to hardcoding this into where we set the defaults.