ipfs files ls without -l is faster #2007
Conversation
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
|
IT'S SO FAST! :D <3 |
| @@ -235,14 +235,33 @@ Examples: | |||
| return | |||
| } | |||
|
|
|||
| long, _, _ := req.Option("l").Bool() | |||
There was a problem hiding this comment.
should this be a proper argument? makes it appear in --help and also makes it easier to find the options this accepts, when reading the code
There was a problem hiding this comment.
i think it is already one -- https://github.com/ipfs/go-ipfs/pull/2007/files#diff-1feff21640e90e71a5ec9ccec2650fbdR217
There was a problem hiding this comment.
oh right, this only reads the option, i mistook it for its definition
@whyrusleeping surprised this didnt break sharness tests-- are there none for this? |
|
@whyrusleeping this LGTM, but before-- what are example outputs? (or, will see it in the sharness test) |
|
@jbenet there will be no noticeable difference in the output of the commands, all thats happening here is that we skip fetching each child node in the case where the caller doesnt care about types (when -l is not specified) |
|
Ah ok, so only the JSON output changes, but commands remain the same. ok LGTM |
ipfs files ls without -l is faster
dont check types of child entries if
-lisnt specified.License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com