Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to display headers for « ipfs object links ». #2333

Merged
merged 2 commits into from
Feb 20, 2016

Conversation

palkeo
Copy link
Contributor

@palkeo palkeo commented Feb 11, 2016

See #1086

@whyrusleeping
Copy link
Member

to fully address #1086 we should make the default not to print this, but add a --headers flag that enables their being printed.

@palkeo palkeo changed the title Remove headers for « ipfs object links ». Add option to display headers for « ipfs object links ». Feb 17, 2016
See ipfs#1086.

License: MIT
Signed-off-by: palkeo <contact@palkeo.com>
@palkeo
Copy link
Contributor Author

palkeo commented Feb 17, 2016

Done. It should be all good now, I think :)

@whyrusleeping
Copy link
Member

last nitpick: run gofmt on your code to fix indentation.

Thanks!

@GitCop
Copy link

GitCop commented Feb 18, 2016

There were the following issues with your Pull Request

  • Commit: 606c1c8
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity.
git commit --amend can often help you quickly improve the commit message.
Guidelines and a script are available to help in the long run.
Your feedback on GitCop is welcome on this issue.


This message was auto-generated by https://gitcop.com

License: MIT
Signed-off-by: palkeo <contact@palkeo.com>
@palkeo
Copy link
Contributor Author

palkeo commented Feb 18, 2016

Done :)

@whyrusleeping
Copy link
Member

Cool, LGTM, thank you! 🚢

whyrusleeping added a commit that referenced this pull request Feb 20, 2016
Add option to display headers for « ipfs object links ».
@whyrusleeping whyrusleeping merged commit 2600a02 into ipfs:master Feb 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants