rewrite add command to use dagwriter #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er for inline pinning
| @@ -72,3 +75,41 @@ func NewDagFromFile(fpath string) (*dag.Node, error) { | |||
|
|
|||
| return NewDagFromReader(f) | |||
| } | |||
|
|
|||
| func NewDagFromFileWServer(fpath string, dserv dag.DAGService, p pin.Pinner) (*dag.Node, error) { | |||
There was a problem hiding this comment.
...WServer ? ...WithService ?
Since these are more complicated construction funcs, no need to adhere to the New... form. Could easily be named: ImportFileDag
There was a problem hiding this comment.
Cool. Ill give them nicer names now, lol
There was a problem hiding this comment.
Also, seems like you could just pass the DagWriter in directly. As in, maybe this function should just be taking a dagwriter.
dw, err := uio.NewDagWriter(dserv, chunk.DefaultSplitter)
if err != nil { ... }
nd, err := import.ImportFileDag(filename, dw) // arg lint error.
|
@whyrusleeping couple of interface comments, otherwise LGTM |
|
|
||
| const ( | ||
| Recursive PinMode = iota | ||
| Direct |
There was a problem hiding this comment.
Strong, weak? (common vocabulary for this operation)
|
@whyrusleeping this failed tests. fixed in f0d823c |
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Oct 23, 2021
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Oct 23, 2021
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Oct 23, 2021
Revert ipfs#236: Test go mod in travis and use major versioning in import paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved a pinner into the dagwriter for inline pinning