Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme: mention building from source on windows #2550

Closed
wants to merge 2 commits into from
Closed

readme: mention building from source on windows #2550

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 12, 2016

Thanks @drwasho

@ghost ghost added the topic/docs-ipfs Topic docs-ipfs label Apr 12, 2016
readme: mention building from source on windows
299d0c1 
Thanks @drwasho

License: MIT
Signed-off-by: Lars Gierth <larsg@systemli.org>
@ghost ghost force-pushed the build-windows branch from b8c5799 to 299d0c1 Compare April 12, 2016 03:12
@ghost ghost mentioned this pull request Apr 12, 2016
Closed
@whyrusleeping
Copy link
Member

I'm not sure how i feel linking to a mutable gist...

@ghost ghost mentioned this pull request Apr 19, 2016
Closed
@djdv
Copy link
Contributor

djdv commented Apr 29, 2016

What about this?
https://github.com/ipfs/go-ipfs/blob/master/docs/windows.md

@chriscool
Copy link
Contributor

@djdv thanks for pointing to the existing doc!

@drwasho your documentation should suggest to build using:

go install -ldflags="-X "github.com/ipfs/go-ipfs/repo/config".CurrentCommit=XXXXXXX"

or:

go build -ldflags="-X "github.com/ipfs/go-ipfs/repo/config".CurrentCommit=XXXXXXX"

Thanks!

@RichardLitt
Added period, capitalized Windows
7c5c353 
License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
@ghost
Copy link
Author

ghost commented May 4, 2016

Thanks @djdv

@ghost ghost closed this May 4, 2016
@whyrusleeping whyrusleeping deleted the build-windows branch May 4, 2016 22:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic/docs-ipfs Topic docs-ipfs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whyrusleeping @djdv @chriscool @RichardLitt