Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs repo version command #2598

Merged
merged 6 commits into from
Jun 4, 2016
Merged

ipfs repo version command #2598

merged 6 commits into from
Jun 4, 2016

Conversation

pfista
Copy link
Contributor

@pfista pfista commented Apr 21, 2016

Fixes #2571

RichardLitt
RichardLitt reviewed Apr 21, 2016
View reviewed changes
core/commands/repo.go
@@ -105,6 +111,7 @@ set of stored objects and print repo statistics. It outputs to stdout:
NumObjects int Number of objects in the local repo.
RepoPath string The path to the repo being currently used.
RepoSize int Size in bytes that the repo is currently taking.
Version string The repo version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs final .

@whyrusleeping
Copy link
Member

@jbenet is this what you were after in #2571 ? (also note my comments there about ipfs version --repo)

@pfista
Copy link
Contributor Author

pfista commented Apr 27, 2016

Once I get confirmation if this is the right direction I'll update the tests as well.

@whyrusleeping whyrusleeping added the kind/support A question or request for support label May 14, 2016
@pfista
Adds repo version info to repo stat command
234afc8 
addresses ipfs#2571

License: MIT
Signed-off-by: Mike Pfister <pfista@gmail.com>
@pfista
Adds repo version subcommand
cd0a33c 
Fixes ipfs#2571

License: MIT
Signed-off-by: Mike Pfister <pfista@gmail.com>
@pfista
Add period to helptext
74e701d 
License: MIT
Signed-off-by: Michael Pfister <pfista@gmail.com>
@pfista
fixing bad rebase
7517bb3 
License: MIT
Signed-off-by: Michael Pfister <pfista@gmail.com>
@pfista
adding tests
53ccaa9 
License: MIT
Signed-off-by: Michael Pfister <pfista@gmail.com>
@pfista
Adding tests for repo stat and repo version cmd
5aaebd0 
License: MIT
Signed-off-by: Michael Pfister <pfista@gmail.com>
@RichardLitt
Copy link
Member

LGTM. @jbenet

@jbenet
Copy link
Member

jbenet commented Jun 4, 2016

yeah LGTM, thanks

@jbenet jbenet merged commit 31d5df5 into ipfs:master Jun 4, 2016
@pfista pfista deleted the 2571-repo-version branch June 4, 2016 04:55
@Kubuxu
Copy link
Member

Kubuxu commented Jun 4, 2016

In this PR non building commits were merged but now it is too late.

@pfista
Copy link
Contributor Author

pfista commented Jun 4, 2016

Sorry, was expecting these to be squashed before merge!

@Kubuxu
Copy link
Member

Kubuxu commented Jun 4, 2016

It isn't your fault in any case, we should have noticed.

@RichardLitt RichardLitt mentioned this pull request Jun 4, 2016
Closed
@jbenet
Copy link
Member

jbenet commented Aug 26, 2016

  • I'm sorry, i didn't notice those.
  • We should not make it possible (or "so green") to merge if some commits have not passed tests...
  • Also we should consider squashing them. (yes, rewriting history)

jbenet
jbenet reviewed Aug 26, 2016
View reviewed changes
test/sharness/t0080-repo.sh
ipfs repo version -q > repo-version-q
'
test_expect_success "repo version came out correct" '
egrep "^fs-repo@[0-9]" repo-version-q >/dev/null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may need to be fs-repo@[0-9]+

@Kubuxu
Copy link
Member

Kubuxu commented Aug 26, 2016

I will follow up.

@Kubuxu Kubuxu assigned Kubuxu and unassigned jbenet Aug 26, 2016
@RichardLitt RichardLitt mentioned this pull request Aug 26, 2016
Closed
4 tasks
@Kubuxu Kubuxu removed their assignment Aug 26, 2016
@jbenet jbenet mentioned this pull request Aug 28, 2016
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/support A question or request for support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pfista @whyrusleeping @RichardLitt @jbenet @Kubuxu