-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dist_get script: prevents get_go_vars() returns same %s-%s values twice #3078
Conversation
This Looks good to me, thank you! If you could sign off on your commit by doing
At the bottom, that will let us get this merged in. |
Sorry for all this mess with git :(, I promise be more careful and read community docs about it the next time. |
No worries! It happens all the time :) On Fri, Aug 12, 2016, 09:56 Ariel Machado notifications@github.com wrote:
|
I don't know why or how to solve but looks GitCop doesn't like my signature when push a merge required after amend comments :/ |
@MrSparc when I look at your branch using
I think you might want to clean that up and that may fix the GitCop problems too. |
@chriscool I just reapplied the patch over here for him: #3079 This can probably be closed. |
- Docker for Mac/Windows is out of beta - docker-machine is recommended for unsupported machines License: MIT Signed-off-by: Zach Ramsay <zach@erisindustries.com>
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
License: MIT Signed-off-by: MrSparc <sparciie@yahoo.com>
Thanks @chriscool for your explanation and sorry again for all this mess wit git... |
This PR fix
bin/dist_get_script
script used to download dependencies.License: MIT
Signed-off-by: MrSparc sparciie@yahoo.com
make install
fails when tries to usedist_get
script to downloadgx
becauseget_go_vars()
method returns the same var valuesGOOS
andGOARCH
twice, ie:gx_v0.8.0_linux-amd64linux-amd64.tar.gz
instead of:
gx_v0.8.0_linux-amd64.tar.gz
This is my first PR on this project, so be friendly please and excuse me if breaking any procedure or mistake :)
Greetings from Portugal!