add a subcommand for the connmgr #4308
Conversation
ghost
assigned 
whyrusleeping
force-pushed
the
feat/connmgr
branch
from
3b8eed8
to
62d5217
Compare
|
(note: this relies on uncommitted changes to the connmgr lib) |
| cmgr := n.PeerHost.ConnManager() | ||
| switch cmgr := cmgr.(type) { | ||
| case nil: | ||
| infos["type"] = "<nil>" |
There was a problem hiding this comment.
Is distinguishing between these two cases really useful? Users aren't going to know what <nil> means.
There was a problem hiding this comment.
They shouldnt ever see "nil", Everything currently will either return a NullConnMgr or a BasicConnMgr. So maybe I should remove it?
There was a problem hiding this comment.
Probably. I'd fail with an error if this isn't supposed to happen.
| infos["type"] = "basic" | ||
|
|
||
| inf := cmgr.GetInfo() | ||
| infos["lowWater"] = inf.LowWater |
There was a problem hiding this comment.
I assume these are supposed to be human readable keys? If so, we should probably just say things like "Low Watermark" instead.
There was a problem hiding this comment.
Those will be the result of JSON endpoint. We can create mappings in TextMarshaller.
|
@whyrusleeping so how about making human readable format having really human readable keys ( |
whyrusleeping
force-pushed
the
feat/connmgr-cmds
branch
2 times, most recently
from
27a5321
to
13beb2e
Compare
|
@GitCop what is your problem? I have that. |
whyrusleeping
force-pushed
the
feat/connmgr-cmds
branch
from
13beb2e
to
67e0293
Compare
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
force-pushed
the
feat/connmgr-cmds
branch
from
67e0293
to
ff55c8f
Compare
|
Can someone take this over for me? |
|
ConnMgr work continued in #9420 |
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com