Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update go-ipfs-cmds #4724

Merged
merged 4 commits into from
Feb 21, 2018
Merged

update go-ipfs-cmds #4724

merged 4 commits into from
Feb 21, 2018

Conversation

Stebalien
Copy link
Member

@Stebalien
update go-ipfs-cmds
2c68c15 
* May fix #4670
* Fixes #4683

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@ghost ghost assigned Stebalien Feb 21, 2018
@ghost ghost added the status/in-progress In progress label Feb 21, 2018
@Stebalien
fix legacy commands test for cmds lib changes
868855f 
cmd.Call no longer returns an error

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien
fix a bunch of go vet errors
45756b6 
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien
remove some dead code
ca3b822 
(it was causing go vet to complain)

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
Stebalien commented Feb 21, 2018
View reviewed changes
commands/request.go
return nil, fmt.Errorf("error parsing timeout option: %s", err)
}

tctx, _ := context.WithTimeout(base, duration)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was making go vet very unhappy.

@whyrusleeping whyrusleeping merged commit 95f308d into master Feb 21, 2018
@whyrusleeping whyrusleeping deleted the gx/update-cmds branch February 21, 2018 04:47
@ghost ghost removed the status/in-progress In progress label Feb 21, 2018
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
@whyrusleeping
Merge pull request ipfs/kubo#4724 from ipfs/gx/update-cmds
2d0f1b9 
update go-ipfs-cmds

This commit was moved from ipfs/kubo@95f308d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

type mismatch panic on ipfs add GC test failure
2 participants
@Stebalien @whyrusleeping