-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] ci: Run ipfs/js-ipfs-http-client & ipfs/interop tests #5053
Conversation
68c2f6d
to
971b64f
Compare
971b64f
to
3925fab
Compare
b8a2ce5
to
9340c71
Compare
I updated js-ipfs-api/interop to latest versions, but there was only 1.5/20 successful passes. the tests also took a ton of time (avg 26min for interop, and ~101min (!) for js-api) @diasdavid @alanshaw Can you have a look at the failures in https://ci.ipfs.team/job/IPFS/job/go-ipfs/job/PR-5053/? Is that caused by the way the tests are invoked here or could something be broken in go-ipfs master? |
hey @magik6k, awesome to see this PR! 💖 js-ipfs-api tests take around 40 minutes right now (they run against go-ipfs): https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fjs-ipfs-api/activity. I'm hoping to decrease that time this quarter. For the js-ipfs 0.31 release I ran the interop tests locally and they all passed. I believe they were also passing on CI... I was under the impression these were working on CI also, ipfs/interop#28 ...can't lookup the history as the jobs have been purged already but it looks like it was also failing here. It would be cool if we could work together to fix this up - I think it's both our responsibilities to create and maintain interop! |
46a9719
to
fff5170
Compare
fff5170
to
ed51ea3
Compare
So I've rebased this and updated js-ipfs-api/interop commits, and it looks like we've broke some things between now and 0.4.17: https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fgo-ipfs/detail/PR-5053/13/tests |
47e9466
to
2cf11ed
Compare
bfffaf0
to
30081a2
Compare
d436b2e
to
7e07e41
Compare
7e07e41
to
df10259
Compare
Rebased again on #5708. |
267484e
to
9c98ff4
Compare
262459a
to
8745a29
Compare
8745a29
to
16d501c
Compare
Rebased for an RC. |
b8bb519
to
eb0e418
Compare
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
eb0e418
to
545fce7
Compare
We don't have Jenkins anymore. |
(Don't delete this branch for now though) |
If it goes missing and you need it, check |
This PR:
TODO: