Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update multiplexers #5075

Merged
merged 1 commit into from
Jun 6, 2018
Merged

update multiplexers #5075

merged 1 commit into from
Jun 6, 2018

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Jun 4, 2018 •
edited
Loading

Updates both the yamux and smux multiplexers (and multistream, for that matter).

License: MIT
Signed-off-by: Steven Allen steven@stebalien.com

@Stebalien
update multiplexers
c9c9986 
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien Stebalien requested a review from Kubuxu as a code owner June 4, 2018 17:07
@ghost ghost assigned Stebalien Jun 4, 2018
@ghost ghost added the status/in-progress In progress label Jun 4, 2018
hsanjuan
hsanjuan approved these changes Jun 4, 2018
View reviewed changes
Copy link
Contributor

@hsanjuan hsanjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it builds and gx deps dupes is empty (or as it was before), this lgtm.

daviddias
daviddias approved these changes Jun 4, 2018
View reviewed changes
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YEAAS! <3

@Stebalien Stebalien added RFM and removed status/in-progress In progress labels Jun 5, 2018
@whyrusleeping whyrusleeping merged commit e094a84 into master Jun 6, 2018
@whyrusleeping whyrusleeping deleted the gx/update-multiplexers branch June 6, 2018 05:03
@daviddias
Copy link
Member

🍾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviddias daviddias daviddias approved these changes

@hsanjuan hsanjuan hsanjuan approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees

@Stebalien Stebalien

Labels
RFM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Stebalien @daviddias @hsanjuan @whyrusleeping