Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Strict Cids #5150

Closed
wants to merge 2 commits into from
Closed

[WIP] Strict Cids #5150

wants to merge 2 commits into from

Conversation

kevina
Copy link
Contributor

@kevina kevina commented Jun 24, 2018

Uses ipfs/go-cid#50 and partly reverts #4751.

@kevina
Revert Most of "Merge pull request #4751 from ipfs/feat/safe-cid"
c6ee301 
This mostly reverts commit 13887ff,
reversing changes made to a544026.

It keeps the fixed to "ipfs pin verify" and a fix to t0050-block.sh to use
a longer block size.
@kevina
Checkpoint.
70949b0
@kevina kevina requested a review from Kubuxu as a code owner June 24, 2018 22:31
@ghost ghost assigned kevina Jun 24, 2018
@ghost ghost added the status/in-progress In progress label Jun 24, 2018
@kevina
Copy link
Contributor Author

kevina commented Jun 24, 2018

And before anyone points it out, I will fix my commits. :)

@kevina kevina mentioned this pull request Jun 25, 2018
Open
@Stebalien
Copy link
Member

@kevina what's the status of this?

@kevina
Copy link
Contributor Author

kevina commented Aug 28, 2018

Stalled. Mainly because I wasn't sure how to test the migration. I get back to it after the base32 migration (and likely the switch to using a string representation for Cid's and Multihashes) is done.

@Stebalien
Copy link
Member

Closing for now as this will need a rebase. DO NOT DELETE

@Stebalien Stebalien closed this May 14, 2019
@hacdias hacdias deleted the kevina/strict-cids branch May 9, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees

@kevina kevina

Labels
status/in-progress In progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevina @Stebalien @GitCop