Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error when publishing ipns records without a running daemon #5477

Merged
merged 4 commits into from
Sep 19, 2018

Conversation

kjzz
Copy link
Contributor

@kjzz kjzz commented Sep 17, 2018

featue #4442

License: MIT
Signed-off-by: Kejie Zhang 601172892@qq.com

License: MIT
Signed-off-by: Kejie Zhang <601172892@qq.com>
License: MIT
Signed-off-by: Kejie Zhang <601172892@qq.com>
License: MIT
Signed-off-by: Kejie Zhang <601172892@qq.com>
@kjzz
Copy link
Contributor Author

kjzz commented Sep 18, 2018

hey @Stebalien , i have update my test ant it has passed required ci .Please help me review it.Thank you.

@ghost ghost assigned Stebalien Sep 19, 2018
@ghost ghost added the status/in-progress In progress label Sep 19, 2018
Better explain what's happening and why.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I just modified the documentation/error a bit). Thanks!

@Stebalien Stebalien merged commit e633ecc into ipfs:master Sep 19, 2018
@ghost ghost removed the status/in-progress In progress label Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants