Serial File Opening #553
Serial File Opening #553
Conversation
| return f.Reader.Read(p) | ||
| } | ||
|
|
||
| func (f *ReaderFile) Close() error { |
There was a problem hiding this comment.
It's better to accept a ReadCloser and allow clients to wrap their non-closing Readers in a Closer wrapper (one which has no effect).
Secretly introspecting and closing a client's Reader is harder to explain to callers and can result in surprising behavior.
There was a problem hiding this comment.
yeah i got bitten by this :/ -- i've since stopped doing it. it's also fine to leave closing to the user in many cases.
There was a problem hiding this comment.
just for the record the NopCloser is here:
package ioutil
func NopCloser(r io.Reader) io.ReadCloser
… cast reader to Closer
|
Strange, I am just starting to play around with ipfs, and apparently got exactly this error: This was with |
This resolves #536.
It creates a new kind of
commands.Filecalled SerialFile, which only needs to open oneos.Fileat a time. It's hella clean since it handles all of the file opening/closing on its own.