fix(commands): support --enc=json in stat #5620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Overbool <overbool.xu@gmail.com>
|
@magik6k could u help me review it? |
magik6k
reviewed
Oct 21, 2018
|
|
||
| if polling { | ||
| fmt.Fprintln(os.Stdout, "Total Up Total Down Rate Up Rate Down") | ||
| // print only once in `--poll` flag | ||
| once.Do(func() { |
There was a problem hiding this comment.
This won't work for multiple invocations of the command, not sure what's the best way to do that. cc @keks
There was a problem hiding this comment.
The proper way to do this is using PostRun. Encoders are for processing individual elements, while PostRun is passed the stream that is emitted by Run and can do transport (e.g. cli or http) specific presentation.
There was a problem hiding this comment.
To clarify: I think we need a second PostRunFunc in the PostRun map with index cmds.JSON.
Kubuxu
reviewed
Oct 22, 2018
| } | ||
| }, | ||
|
|
||
| fmt.Fprintf(os.Stdout, "%8s ", humanize.Bytes(uint64(bs.TotalOut))) |
There was a problem hiding this comment.
We should be also probably be printing into the writer instead of directly to Stdout.
|
(closing due to inactivity) |
jbouwman
pushed a commit
to jbouwman/go-ipfs-cmds
that referenced
this pull request
Aug 19, 2021
Several open issues mention problems with interaction of the global `--encoding=` flag and the Encoders and PostRun fields of command structs. This branch contains experimental refactors that explore approaches to consistent command execution patterns across offline, online and http modes. Specific tickets: - ipfs/kubo#7050 json encoding for `ls` - ipfs/kubo#1121 json encoding for `add` - ipfs/kubo#5594 json encoding for `stats bw` - ipfs#115 postrun design Possibly related: - ipfs/kubo#6640 global flags on subcommands Incomplete PRs: - ipfs/kubo#5620 json for 'stat'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5594
License: MIT
Signed-off-by: Overbool overbool.xu@gmail.com