ping: switch to the ping service enabled in the libp2p constructor #5698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now configure the ping service in go-libp2p by default. Instead of creating a new (duplicate) ping service, we can now just (a) rely on this to handle incoming pings and (b) use the "Ping" function to ping peers. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
ghost
assigned 
vyzo
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now configure the ping service in go-libp2p by default. Instead of creating a new (duplicate) ping service, we can now just (a) rely on this to handle incoming pings and (b) use the "Ping" function to ping peers.
TL;DR: don't register two ping services.