Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gx: update go-libp2p-peer #5975

Merged
merged 2 commits into from
Feb 8, 2019
Merged

gx: update go-libp2p-peer #5975

merged 2 commits into from
Feb 8, 2019

Conversation

Stebalien
Copy link
Member

Switch back to the 0.4.18 style of peer IDs while we figure things out. See libp2p/specs#138.

@Stebalien Stebalien requested a review from Kubuxu as a code owner February 8, 2019 01:12
@ghost ghost assigned Stebalien Feb 8, 2019
@ghost ghost added the status/in-progress In progress label Feb 8, 2019
@Stebalien
Copy link
Member Author

This also pulls the new provider query subsystem for bitswap.

@Stebalien
Copy link
Member Author

And the DHT query queue fixes, and probably a bunch of others.

@Kubuxu
Copy link
Member

Kubuxu commented Feb 8, 2019

Wait, how is Circle passing and everything else failing?

@Kubuxu
Copy link
Member

Kubuxu commented Feb 8, 2019

Circle has separate status for gotest.

Copy link
Member

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test error, might be connected to change of the behaviour in libp2p-peer:

--- FAIL: TestEd22519Publisher (0.00s)
    publisher_test.go:91: datastore: key not found

Switch _back_ to the 0.4.18 style of peer IDs while we figure things out. See
libp2p/specs#138.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien Stebalien force-pushed the gx/update-go-libp2p-peer branch from 545761f to 2c93eef Compare February 8, 2019 01:41
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien Stebalien merged commit 33575e0 into master Feb 8, 2019
@Stebalien Stebalien deleted the gx/update-go-libp2p-peer branch February 8, 2019 04:26
@ghost ghost removed the status/in-progress In progress label Feb 8, 2019
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
gx: update go-libp2p-peer

This commit was moved from ipfs/kubo@33575e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants