Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gomod: Update Dockerfile, remove Dockerfile.fast #6100

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented Mar 19, 2019

The main Dockerfile supports dependencies caching now, rendering
Dockerfile.fast useless.

Resolves #6099

@ghost ghost assigned Kubuxu Mar 19, 2019
@ghost ghost added the status/in-progress In progress label Mar 19, 2019
@Kubuxu Kubuxu requested review from a user and Stebalien March 19, 2019 15:54
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have tests (e.g., sharness) referring to Dockerfile.fast. We'll need to fix those.

The main Dockerfile supports dependencies caching now, rendering
Dockerfile.fast useless.

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu Kubuxu force-pushed the gomod/dockerfile branch from 1529bef to 60a43f8 Compare March 19, 2019 20:10
@Kubuxu
Copy link
Member Author

Kubuxu commented Mar 19, 2019

Fixed

@Kubuxu Kubuxu requested a review from Stebalien March 19, 2019 20:10
@Stebalien Stebalien merged commit e11bbd7 into master Mar 19, 2019
@Stebalien Stebalien deleted the gomod/dockerfile branch March 19, 2019 22:17
@ghost ghost removed the status/in-progress In progress label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants