Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align output for the command ipfs object stat #6181

Closed
wants to merge 3 commits into from
Closed

align output for the command ipfs object stat #6181

wants to merge 3 commits into from

Conversation

myself659
Copy link
Contributor

before align

root@IA:~/ipfs-demo# ipfs object stat QmchMzwpT2c8qWn8JL3bfjTm3hFa45QDRe4DAUBTseitCD
NumLinks: 4
BlockSize: 200
LinksSize: 178
DataSize: 22
CumulativeSize: 947747

after align

root@IA:~/ipfs-demo# ipfs object stat QmchMzwpT2c8qWn8JL3bfjTm3hFa45QDRe4DAUBTseitCD
NumLinks:       4
BlockSize:      200
LinksSize:      178
DataSize:       22
CumulativeSize: 947747

@Stebalien
Copy link
Member

This is a slight breaking change but it should be fine. Could you:

  1. Fix the sharness test?
  2. Add a signoff.

eric wu added 2 commits April 5, 2019 14:12
License: MIT
Signed-off-by: myself659 沉风 <myself659@163.com>
License: MIT
Signed-off-by: Eric Wu <myself659@163.com>
@Stebalien
Copy link
Member

Could you add the commit signoffs?

License: MIT
Signed-off-by: Your Name <email optional>

(we're working on making these unnecessary, sorry)

@myself659
Copy link
Contributor Author

please close this request.
I have started a new request in here

@Stebalien Stebalien closed this Apr 6, 2019
@myself659 myself659 deleted the align-object-stat branch April 7, 2019 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants