add an experiment to prefer TLS 1.3 over secio #6229
Conversation
|
This will need to be reworked a bit for the constructor changes we just merged. Want me to handle that? |
|
That would be great. Thank you! |
License: MIT Signed-off-by: Marten Seemann <martenseemann@gmail.com>
ghost
assigned 
go.mod
Outdated
| @@ -122,3 +124,5 @@ require ( | |||
| ) | |||
|
|
|||
| go 1.12 | |||
|
|
|||
| replace github.com/ipfs/go-ipfs-config => github.com/marten-seemann/go-ipfs-config v0.2.5-0.20190418001109-c95be0eacc9f | |||
There was a problem hiding this comment.
@marten-seemann FYI, you can test PRs that depend on other PRs by adding replace statements.
There was a problem hiding this comment.
I'm aware of that, but I didn't want to put it in a PR, because we might merge it accidentally without removing the replace first.
There was a problem hiding this comment.
I wonder if there's a bot we could employ for that.
License: MIT Signed-off-by: Marten Seemann <martenseemann@gmail.com>
|
I'll bring this up in the standup tomorrow. Assuming nobody objects, we can go ahead and merge it. |
|
Actually, I still want a review from @magik6k on the constructor stuff. |
docs/experimental-features.md
Outdated
|
|
||
| ### State | ||
|
|
||
| Every node accepts secio and TLS 1.3 connections, but prefers secio over TLS when dialing. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
|
💥 Thanks @marten-seemann! |
Depends on ipfs/go-ipfs-config#32.
The CI build is expected to fail until this PR is merged and a release is tagged, which I can then import from this PR.