Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

humanize for ipfs bitswap stat #6258

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Conversation

myself659
Copy link
Contributor

License: MIT
Signed-off-by: Eric Wu myself659@163.com

@Stebalien
Copy link
Member

To match our other commands, we should:

  1. Add a --humanize flag.
  2. Replace the sizes with the humanized sizes when humanizing.

@myself659
Copy link
Contributor Author

my little suggest:
bitswap-stat
as shown in the above picture, I think this way is better with adding --humanize flag. and it has a better user experience.

@myself659
Copy link
Contributor Author

and I think more users will like this type of cmd.

You can discuss it internally. Thx!

@Stebalien
Copy link
Member

So, I'm just trying to be consistent with the rest of go-ipfs. Other commands (ls, du, etc.) provide humanize flags so ifconfig is really the outlier here. Actually, the replacement for ifconfig, ip, also uses a -human flag (ip -s -human addr).

License: MIT
Signed-off-by: Eric Wu <myself659@163.com>
@ghost ghost assigned Stebalien Apr 26, 2019
@ghost ghost added the status/in-progress In progress label Apr 26, 2019
@Stebalien Stebalien merged commit 6e5c251 into ipfs:master Apr 26, 2019
@ghost ghost removed the status/in-progress In progress label Apr 26, 2019
@Stebalien
Copy link
Member

Thanks!

@Stebalien
Copy link
Member

cc @ipfs/wg-js-core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants