fix: make collect-profiles.sh work on mac #6673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version of `date` that ships with darwin does not support the `-Iseconds` flag. Use a pattern with `date` to achieve the same thing but should have better cross platform support. License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
With an empty API headers config like
```js
"API": {
"HTTPHeaders": {}
},
```
running collect-profiles.sh shows connection errors when trying to POST to `/debug/pprof-mutex/` end point when using `localhost`.
The same errors do not occur when using `127.0.0.1`
License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
djdv
approved these changes
Sep 24, 2019
There was a problem hiding this comment.
"timestamp looks the same on my machines" seal-of-approval.
(MSYS2's GNU date, both are supported; OpenIndiana's date, only this PR's format is supported)
localhost causing problems where the loopback ip doesn't, seems odd to me but it's probably better to have it this way anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of
datethat ships with darwin does not support the-Isecondsflag.Use a pattern with
dateto achieve the same thing but should have better cross platform support.Also, makes collect-profiles.sh executable.
License: MIT
Signed-off-by: Oli Evans oli@tableflip.io