Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(coreapi/add): close the fake repo used when adding with hash-only #6747

Merged
merged 1 commit into from
Nov 8, 2019
Merged

fix(coreapi/add): close the fake repo used when adding with hash-only #6747

merged 1 commit into from
Nov 8, 2019

Conversation

Stebalien
Copy link
Member

fixes #6744

@github-actions github-actions bot requested a review from djdv November 4, 2019 18:07
@Stebalien Stebalien requested a review from aschmahmann November 4, 2019 18:08
@Stebalien
Copy link
Member Author

Note: there are actually two issues here:

  1. fix: close peerstore on stop #6629 (fixed).
  2. Closing the node. Technically, this should already mostly happen when the context is canceled. However, it doesn't hurt to explicitly close the node as well.

@Stebalien Stebalien merged commit ec748a7 into master Nov 8, 2019
This was referenced Jan 17, 2020
Closed
Closed
@hacdias hacdias deleted the fix/only-hash-leak branch May 9, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkmc dirkmc dirkmc approved these changes

@djdv djdv Awaiting requested review from djdv

@aschmahmann aschmahmann Awaiting requested review from aschmahmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ipfs add with onlyhash, memery high usage
3 participants
@Stebalien @dirkmc @hcg1314