Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont fail to collect profiles if no ipfs bin #6829

Merged
merged 2 commits into from
Jan 16, 2020
Merged

fix: dont fail to collect profiles if no ipfs bin #6829

merged 2 commits into from
Jan 16, 2020

Commits on Jan 16, 2020

  1. fix: dont fail to collect profiles if no ipfs bin 

    Due to the bash args used, collect-profiles.sh would fail if which ipfs failed to find an ipfs binary on the path, like when running ipfs in docker.

Fixes that by using a check for the command that wont error if it's not found.

Also
- adds a commment to explains when to use the script and what it does.
- be less chatty. Simpify the output so it's clearer what it's doing. Experts can read the script or set the -x flag themselves.

License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
    @olizilla
    olizilla committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    4eb380a View commit details
    Browse the repository at this point in the history

  2. fix: allow profiling of remote node via https 

    License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
    @olizilla
    olizilla committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    982bc38 View commit details
    Browse the repository at this point in the history