Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(peerlog): log protocols/versions #6972

Merged
merged 1 commit into from
Mar 13, 2020
Merged

feat(peerlog): log protocols/versions #6972

merged 1 commit into from
Mar 13, 2020

Conversation

Stebalien
Copy link
Member

No description provided.

@Stebalien Stebalien requested a review from olizilla March 10, 2020 16:32
Copy link
Member

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It blends

⨎ GOLOG_FILE=~/peer.log IPFS_LOGGING_FMT=json ./ipfs daemon
Initializing daemon...
go-ipfs version: 0.5.0-dev-255fefb2a-dirty
...
Daemon is ready
{"level":"info","ts":"2020-03-13T09:34:38.223Z","logger":"plugin/peerlog","caller":"peerlog/peerlog.go:56","msg":"connected","peer":"QmXUEWEWWq6dhKqBwryPSR8jYoa9ByeAaqnz62CRDY7ppL"}
{"level":"info","ts":"2020-03-13T09:34:38.306Z","logger":"plugin/peerlog","caller":"peerlog/peerlog.go:89","msg":"identified","peer":"QmXUEWEWWq6dhKqBwryPSR8jYoa9ByeAaqnz62CRDY7ppL","agent":"/go-ipfs/0.5.0-dev/a44c610","protocols":["/ipfs/id/1.0.0","/ipfs/ping/1.0.0","/libp2p/circuit/relay/0.1.0","/ipfs/kad/1.0.0","/meshsub/1.0.0","/floodsub/1.0.0","/ipfs/bitswap/1.0.0","/x/","/ipfs/id/push/1.0.0","/p2p/id/delta/1.0.0","/libp2p/fetch/0.0.1","/ipfs/bitswap/1.1.0","/ipfs/bitswap"]}
{"level":"info","ts":"2020-03-13T09:34:38.496Z","logger":"plugin/peerlog","caller":"peerlog/peerlog.go:56","msg":"connected","peer":"QmXYHU1M8t86gRKvUmE42smybPKXqTPEUPDUaCVtLmS6Bw"}
{"level":"info","ts":"2020-03-13T09:34:38.640Z","logger":"plugin/peerlog","caller":"peerlog/peerlog.go:89","msg":"identified","peer":"QmXYHU1M8t86gRKvUmE42smybPKXqTPEUPDUaCVtLmS6Bw","agent":"/go-ipfs/0.5.0-dev/a44c610","protocols":["/floodsub/1.0.0","/libp2p/fetch/0.0.1","/ipfs/bitswap/1.1.0","/ipfs/bitswap","/p2p/id/delta/1.0.0","/ipfs/ping/1.0.0","/ipfs/kad/1.0.0","/meshsub/1.0.0","/x/","/ipfs/id/1.0.0","/ipfs/id/push/1.0.0","/libp2p/circuit/relay/0.1.0","/ipfs/bitswap/1.0.0"]}
{"level":"info","ts":"2020-03-13T09:34:39.468Z","logger":"plugin/peerlog","caller":"peerlog/peerlog.go:56","msg":"connected","peer":"12D3KooWFB51PRY9BxcXSH6khFXw1BZeszeLDy7C8GciskqCTZn5"}
{"level":"info","ts":"2020-03-13T09:34:39.614Z","logger":"plugin/peerlog","caller":"peerlog/peerlog.go:89","msg":"identified","peer":"12D3KooWFB51PRY9BxcXSH6khFXw1BZeszeLDy7C8GciskqCTZn5","agent":"dhtbooster/2","protocols":["/ipfs/kad/1.0.0","/ipfs/id/1.0.0","/ipfs/id/push/1.0.0","/p2p/id/delta/1.0.0","/ipfs/ping/1.0.0","/libp2p/circuit/relay/0.1.0"]}
{"level":"info","ts":"2020-03-13T09:34:43.768Z","logger":"plugin/peerlog","caller":"peerlog/peerlog.go:56","msg":"connected","peer":"QmXRfQNqyqy7mFs4B4DXux7QhFBHRtbrRYSyYFAxP2VpaV"}
{"level":"info","ts":"2020-03-13T09:34:44.796Z","logger":"plugin/peerlog","caller":"peerlog/peerlog.go:89","msg":"identified","peer":"QmXRfQNqyqy7mFs4B4DXux7QhFBHRtbrRYSyYFAxP2VpaV","agent":"go-ipfs/0.4.21/","protocols":["/x/","/ipfs/id/1.0.0","/ipfs/id/push/1.0.0","/ipfs/ping/1.0.0","/libp2p/circuit/relay/0.1.0","/ipfs/kad/1.0.0","/ipfs/bitswap/1.1.0","/ipfs/bitswap/1.0.0","/ipfs/bitswap"]}
{"level":"info","ts":"2020-03-13T09:34:44.879Z","logger":"plugin/peerlog","caller":"peerlog/peerlog.go:56","msg":"connected","peer":"QmZCbNvjmUxdAwMX9KxQftQRL1KKASSs7qB21NW5udNM41"}
{"level":"info","ts":"2020-03-13T09:34:44.902Z","logger":"plugin/peerlog","caller":"peerlog/peerlog.go:89","msg":"identified","peer":"QmZCbNvjmUxdAwMX9KxQftQRL1KKASSs7qB21NW5udNM41","agent":"go-ipfs/0.4.22/","protocols":["/libp2p/circuit/relay/0.1.0","/ipfs/bitswap/1.1.0","/ipfs/bitswap/1.0.0","/ipfs/bitswap","/x/","/ipfs/id/push/1.0.0","/ipfs/ping/1.0.0","/ipfs/id/1.0.0","/ipfs/kad/1.0.0"]}

of note, looking at that output it looks like the agent string didn't previously start with a / and now does.

  • "agent":"dhtbooster/2"
  • "agent":"go-ipfs/0.4.21/"
  • "agent":"go-ipfs/0.4.22/"
    vs
  • "agent":"/go-ipfs/0.5.0-dev/a44c610

for consistency with what's out there, perhaps we should revert to not prefixing it with a slash. it otherwise looks like a multiaddr which is confusing.

@Stebalien
Copy link
Member Author

for consistency with what's out there, perhaps we should revert to not prefixing it with a slash. it otherwise looks like a multiaddr which is confusing.

Fixed in #6993.

@Stebalien Stebalien merged commit e0edbe9 into master Mar 13, 2020
@Stebalien Stebalien deleted the feat/log-identify branch March 13, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants