Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choose Key type at initialization #7251

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Choose Key type at initialization #7251

merged 1 commit into from
Jul 14, 2020

Conversation

willscott
Copy link
Contributor

  • should be rebased over a released go-ipfs-config version
  • Add a command for 'rolling over' identity

@willscott willscott requested a review from jacobheun April 29, 2020 17:31
Stebalien
Stebalien reviewed May 1, 2020
View reviewed changes
test/dependencies/go.mod Outdated Show resolved Hide resolved
@willscott willscott force-pushed the feat/ed25519identity branch from 8ee5261 to 2d2cc12 Compare May 1, 2020 23:28
@aschmahmann aschmahmann force-pushed the feat/ed25519identity branch from 33f5df5 to 4eaec06 Compare June 30, 2020 18:55
@aschmahmann aschmahmann mentioned this pull request Jul 1, 2020
Merged
@aschmahmann aschmahmann added the status/blocked Unable to be worked further until needs are met label Jul 2, 2020
@aschmahmann
Copy link
Contributor

This PR seems to be blocked for now by js-ipfs support for Ed25519 IPNS Keys (e.g. libp2p/js-libp2p-crypto#145) as we'd prefer not to roll the defaults to something that'll be problematic for js-ipfs. This shouldn't be blocked for too long, but if it is we can revisit.

@aschmahmann aschmahmann force-pushed the feat/ed25519identity branch from 4eaec06 to 607f2a9 Compare July 7, 2020 22:34
@petar petar force-pushed the feat/ed25519identity branch from 59ee134 to 6780ee4 Compare July 13, 2020 17:28
@petar petar marked this pull request as ready for review July 13, 2020 17:29
@petar petar requested a review from aschmahmann July 13, 2020 17:29
aschmahmann
aschmahmann requested changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. Also, I'm not sure why the interop tests are failing now since the defaults are RSA. Let's rerun them and see if they're still erroring and if so we can ask the JS folks what they think.

cmd/ipfs/init.go Outdated Show resolved Hide resolved
cmd/ipfs/init.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
test/sharness/t0020-init.sh Outdated Show resolved Hide resolved
aschmahmann
aschmahmann reviewed Jul 14, 2020
View reviewed changes
Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to go once we merge + bubble ipfs/go-ipfs-config#105

cmd/ipfs/init.go Outdated Show resolved Hide resolved
test/sharness/t0020-init.sh Outdated Show resolved Hide resolved
test/sharness/t0020-init.sh Outdated Show resolved Hide resolved
aschmahmann
aschmahmann approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aschmahmann aschmahmann changed the title Choose Key type at initialization and switch default to ed25519 Choose Key type at initialization Jul 14, 2020
@petar @willscott @aschmahmann
Choosable key types at initialization
4674f77 
* add support for choosing a peer key type (e.g. RSA or Ed25519) when initializing the repo
* test all variants of ipfs init: RSA, Ed25519 and default
* update subdomain gateway sharness test to publish IPNS using RSA and
Ed25519 keys
* use default identity bit lengths defined in config repo instead of
having separate defaults in go-ipfs
* update config repo dependency

Co-authored-by: Will Scott <will@cypherpunk.email>
Co-authored-by: Petar Maymounkov <petarm@gmail.com>
@aschmahmann aschmahmann force-pushed the feat/ed25519identity branch from cf81c2b to 4674f77 Compare July 14, 2020 18:46
@aschmahmann aschmahmann merged commit b98f797 into master Jul 14, 2020
@aschmahmann aschmahmann self-assigned this Jul 14, 2020
@aschmahmann aschmahmann removed the status/blocked Unable to be worked further until needs are met label Jul 14, 2020
@lidel lidel mentioned this pull request Jul 15, 2020
Merged
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
Closed
72 tasks
@hacdias hacdias deleted the feat/ed25519identity branch May 9, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien left review comments

@petar petar petar left review comments

@aschmahmann aschmahmann aschmahmann approved these changes

@jacobheun jacobheun Awaiting requested review from jacobheun

Assignees

@aschmahmann aschmahmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@willscott @aschmahmann @lidel @petar @Stebalien