when setting config keys, validate against struct before writing to disk #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btc
force-pushed
the
fix/repo-config-validation
branch
from
9f5cfac
to
3d59622
Compare
When setting config keys, the program doesn't know whether the key-to-be-modified exists on the Config struct. (Perhaps, with reflection, it is possible to find the field). To allow callers to write non-existent keys, the program would... Before: 1) converts the in-memory *Config to a map 2) sets the key on the map, and 3) writes this map to disk. 4) Then, it converts this map back into an in-memory struct. This commit swaps 3 and 4 so the map can be validated against the struct before being written to disk. This prevents the bug identified in #740.
btc
force-pushed
the
fix/repo-config-validation
branch
from
3d59622
to
d1da1d4
Compare
|
LGTM. we should probably have tests for both setting/getting the config, and making sure logs dont grow unboundedly (maybe set a low limit, throw N events to go over that limit, and check?). If you want to merge this now, I can write these later. |
btc
pushed a commit
that referenced
this pull request
Feb 4, 2015
when setting config keys, validate against struct before writing to disk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFCR @jbenet @whyrusleeping
This addresses one part of #740. Now, the config is validated before being written to disk. Mismatched types will be rejected instead of being written to disk and breaking the config.