Test for getLocal method in DHT #77
Conversation
| @@ -206,6 +207,11 @@ func TestProvides(t *testing.T) { | |||
| t.Fatal(err) | |||
| } | |||
|
|
|||
| _, err = dhts[3].getLocal(u.Key("hello")) | |||
There was a problem hiding this comment.
while youre at it, verify the value we got back is correct, just for the hell of it
|
You should look at using go's code coverage tools for finding out which code really needs testing: also, reference issue #59 for things relating to test coverage. Finding all the glaring red lines of untested code should give you some good ideas of things you could work on in that regard 👍 |
|
@whyrusleeping this is wonderful! |
|
Isnt that wonderful? Ive actually built tools like this (yay yacc...) by hand before, and having it so "already done" for me is amazing. |
|
At some point, I'd like to set up a Jenkins job to generate html coverage output for every push to master. And push the html to S3 or to ipfs over http for viewing. |
|
screw s3. lets dogfood this shit. |
|
I love your attitude! That would make for a great feedback loop. Filed an issue: |
feat: disable autonat service when in lowpower mode
…onatsvc-lowpower feat: disable autonat service when in lowpower mode
…onatsvc-lowpower feat: disable autonat service when in lowpower mode
…onatsvc-lowpower feat: disable autonat service when in lowpower mode
No description provided.