update QUIC to quic-go v0.19.2 #7769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
From the build failures I'd assume that the stream interface changes are not merged into IPFS yet. Is that correct? |
|
@marten-seemann it wasn't merged in yet because of a bitswap bug that's now fixed so it's in master now. If you rebase it should be fine. |
marten-seemann
force-pushed
the
update-quic
branch
from
6dd355c
to
59a90b4
Compare
|
@aschmahmann I rebased the PR and updated quic-go to v0.19.2. This PR should be ready for review now. |
marten-seemann
changed the title
This was referenced Nov 20, 2020
Closed
aschmahmann
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: v0.19.2 was released, which fixed the bug discovered in v0.19.1. This should be ready to merge now.
I discovered a bug in quic-go v0.19.1 (quic-go/quic-go#2875), which needs to be fixed before we can roll out the new version.