fix: normalize remote service endpoint #7828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
reviewed
Dec 15, 2020
aschmahmann
reviewed
Dec 15, 2020
aschmahmann
reviewed
Dec 15, 2020
aschmahmann
reviewed
Dec 15, 2020
lidel
added a commit
that referenced
this pull request
Dec 15, 2020
aschmahmann
reviewed
Dec 17, 2020
aschmahmann
reviewed
Jan 27, 2021
I don't think we need to worry about #hash, so just removed it
…e not http(s) URIs
aschmahmann
force-pushed
the
fix/normalize-service-endpoint
branch
from
52c1034
to
61f3a2f
Compare
aschmahmann
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds URI normalization for HTTP-based remote pinning service endpoint and applies it:
$IPFS_PATH/config(when user adds viapin remote service add)ps. alternative approach is to address this upstream in go-pinning-service-http-client, but by doing it in
pin remotecommand code we ensure invalid/malformed URIs are not saved to the config file, which is a better UX.