Cosmetic fixups in examples #8325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
petar
commented
Aug 4, 2021
petar
commented
- fix example go.sum
- use common example folder
- spell out complete source of second example (go ipfs with experimental features)
…urce of second example
25 tasks
aschmahmann
reviewed
Aug 5, 2021
aschmahmann
reviewed
Aug 5, 2021
25 tasks
aschmahmann
reviewed
Aug 5, 2021
|
@aschmahmann Addressed comments here. |
|
@aschmahmann Added test. Worked out well. |
|
The test seems to pass, but it doesn't seem to be running in CI. Once it's running then it looks like we're good to go. |
It seems to have passed. |
|
Can we make the tests run when we run |
aschmahmann
approved these changes
Aug 27, 2021
aschmahmann
pushed a commit
that referenced
this pull request
Sep 27, 2021
* test the examples in CI * combine the two examples into a single one (cherry picked from commit c9cc09f)
aschmahmann
pushed a commit
that referenced
this pull request
Sep 27, 2021
* test the examples in CI * combine the two examples into a single one (cherry picked from commit c9cc09f)
aschmahmann
pushed a commit
that referenced
this pull request
Sep 27, 2021
* test the examples in CI * combine the two examples into a single one (cherry picked from commit c9cc09f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.