-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cmds): document deprecated RPC API commands #8802
Conversation
Added programmatic state annotation introduced in ipfs/go-ipfs-cmds#225 for already deprecated / experimental commands.
Leverages Status field from ipfs/go-ipfs-cmds#225 ipfs/kubo#8802 and uses that information while generating HTTP RPC API reference docs.
Helptext: cmds.HelpText{ | ||
Tagline: "List directory contents for Unix filesystem objects. Deprecated: Use 'ipfs ls' instead.", | ||
Tagline: "List directory contents for Unix filesystem objects. Deprecated: Use 'ipfs ls' and 'ipfs files ls' instead.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized we have both an ipfs files
and an ipfs file
(single) command. the horror
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving the use of the new Status
field itself, not the statuses themselves being applied to the commands, which I have not enough context for.
Leverages Status field from ipfs/go-ipfs-cmds#225 ipfs/kubo#8802 and uses that information while generating HTTP RPC API reference docs.
Leverages Status field from ipfs/go-ipfs-cmds#225 ipfs/kubo#8802 and uses that information while generating HTTP RPC API reference docs.
go-ipfs part of ipfs/go-ipfs-cmds#93
This PR adds the programmatic Status annotation introduced in ipfs/go-ipfs-cmds#225
and applies it to for already deprecated / experimental commands.
The main purpose of these annotations is to separate "stable|deprecated|experimental" commands when generating https://docs.ipfs.io/reference/http/api/ (implemented in ipfs/ipfs-docs#1086), but we also show them in
--help
text in CLI:Demo
Deprecated
object
commandsExperimental
name pubsub
commands