fsrepo cleanup: no more components #916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // EventlogComponent.Close was never called. Preserving here | ||
| // pending further discussion. | ||
| // | ||
| // TODO It isn't part of the current contract, but callers may like for us |
|
This LGTM. @tv42 just gave you contributor access so that you can push branches onto the main repo. our jenkins doesn't pick them up otherwise, so not all tests ran here. |
|
@tv42 btw if you have a better way of doing what he pkg-level lock/counters are doing, go for it. i don't remember the intricacy there, but things will get simpler when the cli does not need to touch the config at all. (this will be fixed when repo implements https://github.com/ipfs/specs/tree/master/repo/fs-repo#api ) |
Merged
|
Closing in favor of #917 |
|
@jbenet Yeah I was eyeing those, but decided to go for a more mechanical transformation of the source for now, to not break anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies fsrepo to prepare for future changes. The should be no change in behavior.