Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add WebTransport docs #9308

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Sep 26, 2022

No description provided.

@Jorropo Jorropo marked this pull request as ready for review September 26, 2022 15:39
@Jorropo Jorropo force-pushed the docs/webtransport branch 2 times, most recently from 6518596 to a6720fc Compare September 26, 2022 16:08
@Jorropo
Copy link
Contributor Author

Jorropo commented Sep 26, 2022

Please merge with merge strategy (this is to mirror the same merge on master afterward)

[
"/ip4/0.0.0.0/tcp/4001",
"/ip4/0.0.0.0/udp/4001/quic",
"/ip4/0.0.0.0/udp/4002/quic/webtransport"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why a different port is used for WebTransport's address? Is it because the QUIC address technically takes it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, found a comment in config.md that mentions why. Maybe it should be mentioned here too? I think it'd trip people up if they only saw this example

Copy link
Contributor Author

@Jorropo Jorropo Sep 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already asked the libp2p folks about that.
This is simply because no one wrote the code for your WebTransport transport and your QUIC transport to talk together (and so share the listener) yet.

It might happen in the future, but this is pretty low priority (from the Kubo side of things).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracked in libp2p/go-libp2p#1759. I'm actually planning to land this in the next release, so your migration for generating WebTransport addresses can be as simple as "take all the /quic addresses and add a /webtransport.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx it's exactly what I was hopping to do.

docs/changelogs/v0.16.md Outdated Show resolved Hide resolved
docs/changelogs/v0.16.md Outdated Show resolved Hide resolved
@Jorropo Jorropo merged commit d0ef882 into ipfs:release-v0.16.0 Sep 27, 2022
@Jorropo Jorropo deleted the docs/webtransport branch September 27, 2022 14:54
@Jorropo Jorropo restored the docs/webtransport branch September 27, 2022 14:55
@Jorropo Jorropo deleted the docs/webtransport branch September 27, 2022 14:56
@Jorropo Jorropo restored the docs/webtransport branch December 12, 2022 22:32
@Jorropo Jorropo deleted the docs/webtransport branch December 12, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants