-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add WebTransport docs #9308
Conversation
6518596
to
a6720fc
Compare
Please merge with merge strategy (this is to mirror the same merge on master afterward) |
[ | ||
"/ip4/0.0.0.0/tcp/4001", | ||
"/ip4/0.0.0.0/udp/4001/quic", | ||
"/ip4/0.0.0.0/udp/4002/quic/webtransport" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why a different port is used for WebTransport's address? Is it because the QUIC address technically takes it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, found a comment in config.md that mentions why. Maybe it should be mentioned here too? I think it'd trip people up if they only saw this example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've already asked the libp2p folks about that.
This is simply because no one wrote the code for your WebTransport transport and your QUIC transport to talk together (and so share the listener) yet.
It might happen in the future, but this is pretty low priority (from the Kubo side of things).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracked in libp2p/go-libp2p#1759. I'm actually planning to land this in the next release, so your migration for generating WebTransport addresses can be as simple as "take all the /quic
addresses and add a /webtransport
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx it's exactly what I was hopping to do.
a6720fc
to
32e4963
Compare
32e4963
to
b539cd4
Compare
No description provided.