Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rcmgr): improve error phrasing #9444

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

lidel
Copy link
Member

@lidel lidel commented Dec 1, 2022

This PR makes a cosmetic change to message produced by ResourceMgr as suggested in #9432 (comment):

BEFORE:

ERROR resourcemanager libp2p/rcmgr_logging.go:53    Resource limits were exceeded 2 times with error "system: cannot reserve inbound connection: resource limit exceeded".

AFTER:

ERROR resourcemanager libp2p/rcmgr_logging.go:53    Protected from exceeding resource limits 2 times: "system: cannot reserve inbound connection: resource limit exceeded".

limits were not exceeded, manager protects us from that
#9432 (comment)
Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking there is more we're going to want to do #9432 , but I agree this is a better message so am good with approving it and we can followup with more after.

@ajnavarro ajnavarro merged commit 0976595 into master Dec 2, 2022
@ajnavarro ajnavarro deleted the fix/adjust-rcmgr-error-messages branch December 2, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants