Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: go-libp2p-kad-dht with expiration 48h #9491

Closed
wants to merge 6 commits into from

Conversation

lidel
Copy link
Member

@lidel lidel commented Dec 11, 2022

This PR was made on top of #9423.
It switches to go-libp2p-kad-dht v0.20.0 and closes #9389

We need to include this in 0.18.0-rc1 because republish and expiration bump (#9389)
is marked as required for Kubo 0.18 (#9417)

https://github.com/libp2p/go-libp2p-kad-dht/releases/tag/v0.20.0:

TODO

@lidel
Copy link
Member Author

lidel commented Dec 11, 2022

@Jorropo iiuc tests fail because this PR is made on top of #9423 and that needs to be fixed first – feel free to merge there.

@Jorropo
Copy link
Contributor

Jorropo commented Dec 11, 2022

@lidel thx, I'm working on #9423 now :)

Base automatically changed from update-libp2p-v024 to master December 12, 2022 02:49
@Jorropo
Copy link
Contributor

Jorropo commented Dec 12, 2022

Merged in 3a3a971

@Jorropo Jorropo closed this Dec 12, 2022
@Jorropo Jorropo deleted the feat/update-dht-expiration branch December 12, 2022 02:49
@yiannisbot
Copy link
Member

I'm late to the party as it seems, but all looks good to me here :) Thanks pushing this forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New defaults for the Provider Record Republish and Expiration (22h/48h)
4 participants