Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pollEndpoint: improve error output #952

Merged
merged 1 commit into from
Mar 22, 2015
Merged

Conversation

cryptix
Copy link
Contributor

@cryptix cryptix commented Mar 21, 2015

After seeing the comments on #933, I realized the output of the errors was not good.

It now prints the errors as strings. i.e.:

error="Get http://127.0.0.1:10044/version: dial tcp 127.0.0.1:10044: connection refused"

instead of

error="wrong url or endpoint error from http.Get() &url.Error{Op:\"Get\", RL:\"http://127.0.0.1:5836/version\", Err:(*net.OpError)(0xc208032600)}"

@btc btc added the status/in-progress In progress label Mar 21, 2015
@cryptix cryptix closed this Mar 21, 2015
@btc btc removed the status/in-progress In progress label Mar 21, 2015
@cryptix cryptix reopened this Mar 21, 2015
@btc btc added the status/in-progress In progress label Mar 21, 2015
@cryptix
Copy link
Contributor Author

cryptix commented Mar 22, 2015

re-opened to get the tests running again but it only affected the travis-ci/pr not /push.

The faillure was a known fluke:

--- FAIL: TestBootstrap (1.23 seconds)
    dht_test.go:314: connecting 30 dhts in a ring
    dht_test.go:77: dial attempt failed
01:38:44.557 CRITI   boguskey: TestBogusPrivateKey.Sign -- this better be a test! <autogenerated>:21
FAIL
FAIL    github.com/jbenet/go-ipfs/routing/dht   5.049s

ps: rebased

jbenet added a commit that referenced this pull request Mar 22, 2015
@jbenet jbenet merged commit 41e93f6 into master Mar 22, 2015
@jbenet jbenet removed the status/in-progress In progress label Mar 22, 2015
@jbenet jbenet deleted the tests/pollEndpointErrors branch March 22, 2015 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants