-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(gateway): use deterministic CAR fixtures #9657
test(gateway): use deterministic CAR fixtures #9657
Conversation
b1492fb
to
a4086e6
Compare
ff609da
to
89e62af
Compare
c0a3bdb
to
8e636e6
Compare
1478aa1
to
1ed8b35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me. This is very nice 😃 I left some inline comments.
f4cd620
to
92a068a
Compare
Thanks for the review @hacdias, I patched your comments,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-run the go test
in GitHub and it's fine now. There are a few flaky tests and they seem to fail more often in GitHub Actions than Circle CI actually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @laurentsenta! ❤️
This work is not only unblocking work on gateway conformance test suite that is not tied to Kubo, but ALSO reduces the surface work for switching ipfs add
to produce CIDv1 by default.
I checked success ratios of
Overall, it seems we're pretty much on track to be able to disable CircleCI. I'll dig into the data more before the final cleanup PR but there's nothing worrying standing out. Here's the WIP GHA monitoring dashboard if you want a peek: https://protocollabs.grafana.net/d/gieYOhbVk/github-actions-ipfs-kubo?orgId=1&from=now-3d&to=now (cc @BigLep since I think you might be interested ;) |
@galargh interesting. My "it seems" is just based on my observations on my PRs specifically, so I might just be unlucky :P Thanks for the link! |
Contributes to #9654
ipns(not doing ipnfs yet)t0124-gateway-ipns-record.sh(not doing ipns yet)