Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracing): use OTEL_PROPAGATORS as per OTel spec #9801

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Apr 6, 2023

@hacdias hacdias requested a review from Jorropo April 6, 2023 13:20
@hacdias hacdias marked this pull request as ready for review April 6, 2023 13:26
@hacdias hacdias requested a review from lidel as a code owner April 6, 2023 13:26
@hacdias hacdias self-assigned this Apr 6, 2023
@hacdias
Copy link
Member Author

hacdias commented Apr 6, 2023

The proof via cat'ing as requested by @Jorropo

image

make build
OTEL_TRACES_EXPORTER=jaeger ./cmd/ipfs/ipfs daemon
OTEL_TRACES_EXPORTER=jaeger ./cmd/ipfs/ipfs cat bafkreifjjcie6lypi6ny7amxnfftagclbuxndqonfipmb64f2km2devei4

Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should reconsider screenshot based test suite but testing tracing sounds painfull.

@hacdias
Copy link
Member Author

hacdias commented Apr 6, 2023

@Jorropo yeah, we have a small test for the Boxo example because we can. In Kubo seems much harder to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants