fix: use default HTTP routers when FullRT DHT client is used #9841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guseggert
force-pushed
the
fix/fullrt-http-routing
branch
from
50c37a6 to
9c132e1
Compare
guseggert
force-pushed
the
fix/fullrt-http-routing
branch
from
9c132e1 to
7f05c65
Compare
This was referenced May 2, 2023
Closed
hacdias
pushed a commit
that referenced
this pull request
May 3, 2023
hacdias
pushed a commit
that referenced
this pull request
May 3, 2023
hacdias
pushed a commit
that referenced
this pull request
May 3, 2023
guseggert
added a commit
that referenced
this pull request
May 3, 2023
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
May 7, 2023
Highlights FullRT DHT HTTP Routers The default HTTP routers are now used when the FullRT DHT client is used. This fixes the issue where cid.contact is not being queried by default when the accelerated DHT client was enabled. Read more in (ipfs/kubo#9841).
hacdias
pushed a commit
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change
It was discovered here that cid.contact was not being queried by default when the accelerated DHT client was enabled. Node operators like the ipfs.io gateway were affected this. This change achieves the intended 0.18 behavior of querying the DHT and cid.contact in parallel even when the accelerated DHT is enabled.
Testing Details
I wrote some tests for this but I couldn't get them to be non-racy, so I'm excluding from this for expediency's sake. I'll keep trying to get them to work and hopefully I can include them in a followup PR. We don't otherwise have any integ tests for the accelerated DHT client.
Otherwise, I tested this by running locally and looking at the prometheus metrics.