Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ipns): records with V2-only signatures #9932

Merged
merged 4 commits into from
Jun 20, 2023
Merged

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Jun 12, 2023

See ipfs/boxo#339.

  • Note that this also removes the REFRAME routing support. It has been deprecated and the deprecated package has conflicts with the changes we made to boxo/ipns. It wouldn't make sense to update it since it's deprecated (HTTP Router only uses Addresses.Swarm #9823 (comment)).

@hacdias hacdias force-pushed the boxo/refactor-ipns branch 3 times, most recently from 68fdeba to 0a5140a Compare June 12, 2023 09:07
@hacdias hacdias self-assigned this Jun 12, 2023
@hacdias hacdias marked this pull request as ready for review June 12, 2023 09:13
@hacdias hacdias requested a review from a team as a code owner June 12, 2023 09:13
@hacdias hacdias force-pushed the boxo/refactor-ipns branch from b0747a2 to f6164e2 Compare June 13, 2023 11:27
@hacdias hacdias changed the title refactor: upgrade to refactored IPNS package feat: upgrade boxo for refactored boxo/ipns package Jun 13, 2023
@hacdias hacdias force-pushed the boxo/refactor-ipns branch 7 times, most recently from 6bbf30e to e5ffac7 Compare June 14, 2023 09:06
@hacdias hacdias force-pushed the boxo/refactor-ipns branch 2 times, most recently from 87ef459 to 07067dd Compare June 14, 2023 10:42
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Lgtm, but needs tests, probably in test/sharness/t0100-name.sh (fine to add or migrate them to test/cli/harness if you dont want to write bash)

  • ipfs name publish + resolve + inspect with and without v1compat

core/commands/name/publish.go Outdated Show resolved Hide resolved
core/commands/name/publish.go Outdated Show resolved Hide resolved
@hacdias hacdias force-pushed the boxo/refactor-ipns branch 2 times, most recently from 3dc8fed to 22dd4b9 Compare June 15, 2023 13:27
@hacdias hacdias requested a review from lidel June 15, 2023 13:31
@hacdias hacdias force-pushed the boxo/refactor-ipns branch from 22dd4b9 to d5d3b91 Compare June 16, 2023 06:54
@hacdias hacdias force-pushed the boxo/refactor-ipns branch 3 times, most recently from 5553fa2 to 49112b6 Compare June 16, 2023 07:02
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some UX papercuts and missing tests need to be addressed (details below),
and needs to be rebased after ipfs/boxo#339 lands,
but otherwise lgtm.

@hacdias do you think we should include this in 0.21 (#9814), or do we do push both to 0.22? Since V2-only is opt-in, it should be safe to ship sooner, but ok to play it safe and push to 0.22

core/commands/name/name.go Outdated Show resolved Hide resolved
test/cli/name_test.go Show resolved Hide resolved
test/cli/name_test.go Outdated Show resolved Hide resolved
docs/changelogs/v0.22.md Outdated Show resolved Hide resolved
core/commands/name/name.go Outdated Show resolved Hide resolved
core/commands/name/name.go Outdated Show resolved Hide resolved
core/commands/name/name.go Outdated Show resolved Hide resolved
core/commands/name/name.go Outdated Show resolved Hide resolved
test/cli/name_test.go Show resolved Hide resolved
@lidel lidel changed the title feat: upgrade boxo for refactored boxo/ipns package feat: opt-in IPFS records with V2-only signatures Jun 20, 2023
@lidel lidel changed the title feat: opt-in IPFS records with V2-only signatures feat(ipns): records with V2-only signatures Jun 20, 2023
@hacdias hacdias force-pushed the boxo/refactor-ipns branch from bda9a17 to 737c660 Compare June 20, 2023 11:57
@hacdias
Copy link
Member Author

hacdias commented Jun 20, 2023

@lidel I addressed the feedback and merged on Boxo side. I will be merging here once CI passes.

Regarding Kubo 0.21: I don’t mind either way. If we do an RC4 (let’s hope not), I will include it. Otherwise, let’s move it to Kubo 0.22. In case we don’t want to include it in Kubo 0.21 and there’s an RC4, I do not mind doing a cherry-picked release.

For now, I will assume 0.22 - if we end up doing RC4, I will update the changelog accordingly.

@hacdias hacdias merged commit 5156f21 into master Jun 20, 2023
@hacdias hacdias deleted the boxo/refactor-ipns branch June 20, 2023 12:24
@BigLep BigLep mentioned this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants