refactor(rcmgr): use default libp2p rcmgr metrics #9947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why sharness is failing. Has something to do with Prometheus metrics. I don't have a sharness setup locally, so I won't be able to debug this. I'd also argue (again) that it doesn't make sense to have any test that asserts what metrics downstream libraries are exposing. |
|
Triage note: @Jorropo will take a look |
Jorropo
force-pushed
the
libp2p-rcmgr-metrics
branch
from
3ba1080 to
cd25750
Compare
Closed
lidel
force-pushed
the
libp2p-rcmgr-metrics
branch
from
61c83f0 to
887c036
Compare
lidel
changed the title
we no longer expect those extra ones
lidel
reviewed
Nov 27, 2024
There was a problem hiding this comment.
This is a nice cleanup.
The sharness was failing because we have early warning when exposed metrics change, and this PR introduced diff:
-libp2p_rcmgr_memory_allocations_allowed_total
-libp2p_rcmgr_memory_allocations_blocked_total
-libp2p_rcmgr_peer_blocked_total
-libp2p_rcmgr_peers_allowed_totalRebased, updated tests and added changelog entry informing people about removal, and that Kubo switched to upstream ones.
Once CI is green, will ship in 0.33.
lidel
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the bespoke rcmgr metrics with the default libp2p metrics. This allows us to use the libp2p-maintained dashboard on all of our Grafana instances.
It would be great if this could be merged for the v0.21 release. There've been quite a few instances recently where libp2p dashboards have helped us pinpoint a problem. Not having rcmgr metrics has made debugging more complicated than necessary.