Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed old drafts, added new one #6

Merged
merged 7 commits into from
Jan 8, 2016
Merged

Removed old drafts, added new one #6

merged 7 commits into from
Jan 8, 2016

Conversation

RichardLitt
Copy link
Member

Alright, this is the draft for this week's roundup. Thoughts?

You have 24 hours to respond before I post this on the Blog and on IPFS/IPFS. That means by Jan 7, at 2200 UTC.

@eminence
Copy link
Contributor

eminence commented Jan 6, 2016

For this week only, maybe add a small text in the opening paragraph along the lines of:

Since this is our first time doing this, we've included several past weeks, but in the future they will be released weekly

@RichardLitt
Copy link
Member Author

@eminence That is really weird, I had written that into a paragraph, but I seem to have deleted it. Will add that in again, now.

@RichardLitt
Copy link
Member Author

@eminence Added. Also added our names at the bottom, and a feedback link.

@RichardLitt RichardLitt mentioned this pull request Jan 7, 2016
3 tasks
* Travis Person
* digital dreamer
* dignifiedquire
* greenkeeperio-bot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bots reserve love and recognition too, you know!

@Kubuxu
Copy link
Member

Kubuxu commented Jan 7, 2016

There is also mix of protocol and protocol-less hyperlinks. It is not a big issue but using one style would be better.

Across the entire IPFS github organization, the following people have comitted code since December 7th. (We're autogenerating this list using [this tool](https://github.com/ipfs/weekly/pull/5), so please let us know if your name isn't here.) In the future, we will also include people who comment, as they are also super important; bear with us while we develop that technology.


* Adam Gashlin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think these names should be fromatted as:

- @githubusername (Real Name)

we use github usernames for everything else, but yes we should have real names here (IF they show the real name on github or the commit. if github and the commit do not have the real name, respect their privacy)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed. the username comes from git, so i consider it to be what the user would like to be publicly identified as. the only mapping done is when it is obvious that a nickname is an alias for a public real name.

we don't list the github handles at the moment because we don't have a good way to get them. this will be fixed in the future though

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got them all manually. We can automatically do this in the future.

@jbenet
Copy link
Member

jbenet commented Jan 7, 2016

3 comments above, otherwise this LGTM. thanks guys this is a great, great start

@RichardLitt
Copy link
Member Author

Cool. I addressed all comments, I think adequately.

@eminence
Copy link
Contributor

eminence commented Jan 8, 2016

24 hours is up! let's merge this sucker!

@whyrusleeping
Copy link
Member

do ittt

@whyrusleeping
Copy link
Member

RichardLitt added a commit that referenced this pull request Jan 8, 2016
Removed old drafts, added new one
@RichardLitt RichardLitt merged commit 048c66e into master Jan 8, 2016
@RichardLitt RichardLitt deleted the feature/jan-5 branch January 8, 2016 15:33
@jbenet
Copy link
Member

jbenet commented Jan 8, 2016

Awesome! 👍 👏 👏 👏

:shipit:


embedded:

@jbenet
Copy link
Member

jbenet commented Jan 9, 2016 via email

RichardLitt added a commit that referenced this pull request Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants