Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): skip test if no code changed #210

Merged
merged 1 commit into from
Mar 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Hello! To ensure this PR is correctly addressed as soon as possible by the IPFS

IF ADDING A NEW PUBLIC GATEWAY:
- Name your PR in the format `feat: add gateway.address.here`
- Make sure there is no trailing comma in the final gateway in the list at `gateways.json`
- Make sure there is no trailing comma in the final gateway in the list at `src/gateways.json`
- Include a brief description of the gateway to be added (e.g. geographic location, connection speed, available space, etc)

ALL OTHER PULL REQUESTS:
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/js-test-and-release.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
name: test & maybe release
name: test
on:
push:
paths-ignore:
- 'README.md'
- 'src/gateways.json'
branches:
- master # with #262 - ${{{ github.default_branch }}}
pull_request:
paths-ignore:
- 'README.md'
- 'src/gateways.json'
branches:
- master # with #262 - ${{{ github.default_branch }}}

Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ View the Public Gateway Checker on GitHub Pages: https://ipfs.github.io/public-g

## Adding a new public gateway

If you'd like to add a new public gateway, please edit `gateways.json`:
If you'd like to add a new public gateway, please edit `./src/gateways.json`:

1. Add the gateway's address to the bottom of the list
2. Make sure the final item in the list does **not** have a comma at the end, but all preceding items do
Expand All @@ -24,6 +24,7 @@ Then, submit a pull request for this change. Be sure to follow all the direction
## Testing locally

```bash
npm ci
npm run build
npm start
```
Expand Down
Loading