Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: required ci test on ignored paths #328

Closed
wants to merge 1 commit into from
Closed

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Nov 7, 2022

Many PRs in this repository are stuck waiting for the test workflow even though they have been approved (#321, #323, #326). The problem is that the test workflow is skipped for the gateways.json and README.md files. As per GitHub's own suggestions this PR brings a "fake" workflow with the same name that executes on the paths ignored by the real workflow. This simply passes the test, giving it a green checkmark.

After this PR, the following should happen:

  • js-test-and-release.yaml runs except when only gateways.json and README.md are modified
  • js-test-and-release-skip.yaml runs when only gateways.json and README.md are modified

Then, update all the mentioned PRs to unblock them.

@hacdias hacdias requested a review from a team as a code owner November 7, 2022 10:13
@lidel
Copy link
Member

lidel commented Nov 7, 2022

I've made fleek/build mandatory instead – should make reviews easier until we have proper CI that does proper tests ;)

@lidel lidel closed this Nov 7, 2022
@hacdias hacdias deleted the fix/required-test branch November 7, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants