Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add storry.tv #550

Merged
merged 1 commit into from
Apr 10, 2024
Merged

feat: add storry.tv #550

merged 1 commit into from
Apr 10, 2024

Conversation

StorryTV
Copy link
Contributor

@StorryTV StorryTV commented Apr 4, 2024

The gateway was removed from the list, because of some issues/bots making the gateway not respond.

Most issues should be fixed for now as the gateway is online and working fine again.

In the readme.md it says "Add the gateway's address to the top of the list", so therefore I added it to the top.

The gateway was removed from the list, because of some issues/bots making the gateway not respond.

Most issues should be fixed for now as the gateway is online and working fine again.

In the readme.md it says "Add the gateway's address to the top of the list", so therefore I added it to the top.
@StorryTV StorryTV requested a review from a team as a code owner April 4, 2024 18:41
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. FYI that gateway is pointing to a peerid,

╰─ ✔ ❯ dig +noall +answer TXT _dnslink.storry.tv
_dnslink.storry.tv.	300	IN	TXT	"dnslink=/ipns/k51qzi5uqu5divzv9t0v3y6zqxlbk1fbfb7epuiknkocn9iuaf2hl33ybrqqyx/"

and when checking the published multiaddrs of that peer, it seems like you're publishing some private addresses: https://pl-diagnose.on.fleek.co/#/diagnose/access-content?addr=%2Fip4%2F127.0.0.1%2Ftcp%2F4001%2Fp2p%2F12D3KooWH8959NL8N3ggiHxYsSDe3ddvgUBEUpReJPfyEXBJPhWQ&backend=https%3A%2F%2Fpl-diagnose.onrender.com

image

not a blocker here, but publishing only public addresses can help make sure your node can be dialed more easily (if you want it to be found accessible by peers instead of only at storry.tv)

@2color
Copy link
Member

2color commented Apr 10, 2024

Seems to be failing the tests in the preview build, due to CORS not being enabled:
Screenshot 2024-04-10 at 11 05 14 am

@StorryTV
Copy link
Contributor Author

@SgtPooki Thanks for letting me know.

Private adresses are not being announced anymore.

@StorryTV
Copy link
Contributor Author

@2color The issue was the server blocking the request too aggressively because of a keyword inside the referrer url "https://bafybeifxpdtl377uykct2jseo47l4qivdqi7ycokayg4yqpsa2wwswymfa.on.fleek.co/"

Also fixed this.

It should work now.

@SgtPooki SgtPooki merged commit 127e5eb into ipfs:main Apr 10, 2024
18 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 10, 2024
## [1.10.0](v1.9.6...v1.10.0) (2024-04-10)

### Features

* add storry.tv ([#550](#550)) ([127e5eb](127e5eb))

### Trivial Changes

* **deps-dev:** bump typescript from 5.1.6 to 5.4.4 ([#551](#551)) ([eaa45c1](eaa45c1))
* update conformance results ([0723c33](0723c33))
Copy link

🎉 This PR is included in version 1.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@StorryTV StorryTV deleted the patch-1 branch April 11, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants