-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add storry.tv #550
feat: add storry.tv #550
Conversation
The gateway was removed from the list, because of some issues/bots making the gateway not respond. Most issues should be fixed for now as the gateway is online and working fine again. In the readme.md it says "Add the gateway's address to the top of the list", so therefore I added it to the top.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. FYI that gateway is pointing to a peerid,
╰─ ✔ ❯ dig +noall +answer TXT _dnslink.storry.tv
_dnslink.storry.tv. 300 IN TXT "dnslink=/ipns/k51qzi5uqu5divzv9t0v3y6zqxlbk1fbfb7epuiknkocn9iuaf2hl33ybrqqyx/"
and when checking the published multiaddrs of that peer, it seems like you're publishing some private addresses: https://pl-diagnose.on.fleek.co/#/diagnose/access-content?addr=%2Fip4%2F127.0.0.1%2Ftcp%2F4001%2Fp2p%2F12D3KooWH8959NL8N3ggiHxYsSDe3ddvgUBEUpReJPfyEXBJPhWQ&backend=https%3A%2F%2Fpl-diagnose.onrender.com
not a blocker here, but publishing only public addresses can help make sure your node can be dialed more easily (if you want it to be found accessible by peers instead of only at storry.tv)
Seems to be failing the tests in the preview build, due to CORS not being enabled: |
@SgtPooki Thanks for letting me know. Private adresses are not being announced anymore. |
@2color The issue was the server blocking the request too aggressively because of a keyword inside the referrer url "https://bafybeifxpdtl377uykct2jseo47l4qivdqi7ycokayg4yqpsa2wwswymfa.on.fleek.co/" Also fixed this. It should work now. |
🎉 This PR is included in version 1.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
The gateway was removed from the list, because of some issues/bots making the gateway not respond.
Most issues should be fixed for now as the gateway is online and working fine again.
In the readme.md it says "Add the gateway's address to the top of the list", so therefore I added it to the top.